ldb_dn_copy(): should we take a talloc_reference?

[Volker Lendecke]

On Mon, Feb 12, 2018 at 11:48:47AM -0800, Jeremy Allison wrote:
> If you have to reference count, add an explicit reference
> counter.

There's one use of talloc_reference that that I would defend: It's in
tdb_wrap. There it's impossible that anybody outside of this small
piece of code can be affected. The alternative would have been an
explicit refcount, but that has its complexities too. If you confine
it like tdb_wrap does, it is essentially an explicit refcount with
other means.

Volker

-- 
Besuchen Sie die verinice.XP 2018 in Berlin,
Anwenderkonferenz für Informationssicherheit
vom 21.-23.03.2018 im Sofitel Kurfürstendamm
Info & Anmeldung hier: http://veriniceXP.org

SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de