[PATCH] try to fix flapping user_wdigest test

Andreas Schneider asn at samba.org
Mon Feb 12 13:55:22 UTC 2018


On Monday, 12 February 2018 00:28:35 CET Douglas Bagnall via samba-technical 
wrote:
> Since 4.8 forked about a month ago, there have been 3 cases of this:
> 
> UNEXPECTED(failure):
> samba.tests.samba_tool.user_wdigest.samba.tests.samba_tool.user_wdigest.Use
> rCmdWdigestTestCase.test_Wdigest01(ad_dc_ntvfs:local)
> 
> which is only exceeded by the 5 of these:
> 
> UNEXPECTED(failure): samba4.blackbox.trust_ntlm.Test05 rpcclient getusername
> with UNKNOWNDOMAIN\autobuild%localnt4member3pass(nt4_member:local)
> 
> There were 5 other user_wdigest failures since the test first appeared last
> May.
> 
> The most common traceback is:
> 
> UNEXPECTED(failure):
> samba.tests.samba_tool.user_wdigest.samba.tests.samba_tool.user_wdigest.Use
> rCmdWdigestTestCase.test_Wdigest01(ad_dc_ntvfs:local) REASON: Exception:
> Exception: Traceback (most recent call last):
>   File
> "/memdisk/autobuild/fl/b567838/samba/bin/python/samba/tests/samba_tool/user
> _wdigest.py", line 134, in test_Wdigest01 self._testWDigest(attribute,
> expected)
>   File
> "/memdisk/autobuild/fl/b567838/samba/bin/python/samba/tests/samba_tool/user
> _wdigest.py", line 111, in _testWDigest self.assertMatch(result, "%s: %s" %
> (attribute, expected))
>   File
> "/memdisk/autobuild/fl/b567838/samba/bin/python/samba/tests/samba_tool/base
> .py", line 92, in assertMatch self.assertTrue(string in base, msg)
> AssertionError: False is not true
> 
> though there were a couple of stranger ones in the early days.
> 
> It seems to me that the most likely cause of this traceback is over-eager
> unwrapping of line-wrapped ldif. But I can't reproduce it, and the assertion
> doesn't give us too many clues.
> 
> Douglas


RB+

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org





More information about the samba-technical mailing list