[PATCH] try to fix flapping user_wdigest test

Douglas Bagnall douglas.bagnall at catalyst.net.nz
Sun Feb 11 23:28:35 UTC 2018

Since 4.8 forked about a month ago, there have been 3 cases of this:

UNEXPECTED(failure): samba.tests.samba_tool.user_wdigest.samba.tests.samba_tool.user_wdigest.UserCmdWdigestTestCase.test_Wdigest01(ad_dc_ntvfs:local)

which is only exceeded by the 5 of these:

UNEXPECTED(failure): samba4.blackbox.trust_ntlm.Test05 rpcclient getusername with UNKNOWNDOMAIN\autobuild%localnt4member3pass(nt4_member:local)

There were 5 other user_wdigest failures since the test first appeared last May.

The most common traceback is:

UNEXPECTED(failure): samba.tests.samba_tool.user_wdigest.samba.tests.samba_tool.user_wdigest.UserCmdWdigestTestCase.test_Wdigest01(ad_dc_ntvfs:local)
REASON: Exception: Exception: Traceback (most recent call last):
  File "/memdisk/autobuild/fl/b567838/samba/bin/python/samba/tests/samba_tool/user_wdigest.py", line 134, in test_Wdigest01
    self._testWDigest(attribute, expected)
  File "/memdisk/autobuild/fl/b567838/samba/bin/python/samba/tests/samba_tool/user_wdigest.py", line 111, in _testWDigest
    self.assertMatch(result, "%s: %s" % (attribute, expected))
  File "/memdisk/autobuild/fl/b567838/samba/bin/python/samba/tests/samba_tool/base.py", line 92, in assertMatch
    self.assertTrue(string in base, msg)
AssertionError: False is not true

though there were a couple of stranger ones in the early days.

It seems to me that the most likely cause of this traceback is over-eager
unwrapping of line-wrapped ldif. But I can't reproduce it, and the assertion
doesn't give us too many clues.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: user_wdigest.patch
Type: text/x-patch
Size: 3412 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180212/a6b006c7/user_wdigest.bin>

More information about the samba-technical mailing list