[PATCH] Port of dsdb, dsdb_dns and samdb Python modules

[Lumir Balhar]

On 02/08/2018 10:10 PM, Andrew Bartlett wrote:
> Sorry to nitpick, but why do we need the addCleanup and the tearDown?
>
> On Thu, 2018-02-08 at 10:56 +0100, Andreas Schneider wrote:
>> +    def tearDown(self):
>> +        delete_force(self.samdb, self.account_dn)
> At worse it doesn't do anything, but this looks wrong.
>
> I'm just waiting for a reply from Lumir regarding this and I can give
> my review:
Sorry for the delay. I just forgot to remove debug print. Attaching the 
new patchset based on the latest one in this thread. Is it okay or 
should I change something else?

Thank you very much for the cooperation and quick responses. I am 
working on another patches based on this patchset.

Have a nice weekend.

Lumír
>
> In:
>
> python: Port samdb module to Python 3 compatible form
>
> This still has:
>
> +            print(password, PY3)
>
> and is there really no common way of doing this?
>
> +            if PY3:
> +                pw = str('"' + password + '"').encode('utf-16-le')
> +            else:
> +                pw = unicode('"' + password.encode('utf-8') + '"', 'utf-8').encode('utf-16-le')
>
>
> Thanks for your patience on this!
>
> Andrew Bartlett
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-python-tests-Make-tests-of-dsdb-Python-module-Python.patch
Type: text/x-patch
Size: 5923 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180209/09aaccd3/0006-python-tests-Make-tests-of-dsdb-Python-module-Python.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-python-Port-dsdb-module-to-Python-3-compatible-form.patch
Type: text/x-patch
Size: 8339 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180209/09aaccd3/0005-python-Port-dsdb-module-to-Python-3-compatible-form.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-python-Port-samdb-module-to-Python-3-compatible-form.patch
Type: text/x-patch
Size: 3581 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180209/09aaccd3/0004-python-Port-samdb-module-to-Python-3-compatible-form.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-python-Port-dsdb_dns-module-to-Python-3-compatible-f.patch
Type: text/x-patch
Size: 2366 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180209/09aaccd3/0003-python-Port-dsdb_dns-module-to-Python-3-compatible-f.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-python-Convert-base64-encoded-password-to-utf-8.patch
Type: text/x-patch
Size: 841 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180209/09aaccd3/0002-python-Convert-base64-encoded-password-to-utf-8.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-python-Generate-random-test-usernames.patch
Type: text/x-patch
Size: 1594 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180209/09aaccd3/0001-python-Generate-random-test-usernames.bin>