[PATCH] a couple more small patches

jim jim.brown at rsmas.miami.edu
Fri Feb 9 05:23:56 UTC 2018


While you are here would it make sense to change 'except Exception, e:' 
to use "as" instead of ","?

On 2/8/2018 11:23 PM, Douglas Bagnall via samba-technical wrote:
>           req1 = drsuapi.DsReplicaGetInfoRequest1()
>           req1.info_type = info_type
>           try:
> -            (info_type, info) = ctx.drsuapi.DsReplicaGetInfo(ctx.drsuapi_handle, 1, req1)
> +            (info_type, info) = self.drsuapi.DsReplicaGetInfo(
> +                self.drsuapi_handle, 1, req1)
>           except Exception, e:
>               raise CommandError("DsReplicaGetInfo of type %u failed" % info_type, e)
>           return (info_type, info)




More information about the samba-technical mailing list