[PATCH] Make g_lock use a TDB_DATA key

Ralph Böhme slow at samba.org
Thu Feb 8 08:25:17 UTC 2018

On Thu, Feb 08, 2018 at 08:55:02AM +0100, Volker Lendecke via samba-technical wrote:
> locking.tdb has the problem that we do file system calls while holding
> locks on the tdb. This can cause big trouble for clustered
> environments. g_lock with its g_lock_write_data can remove this
> trouble by forming the basis for locking.tdb: Drop mutexes/fcntl-locks
> while doing the file system syscalls. This is step 0 for this:
> locking.tdb is unhappy with strings as keys, it needs TDB_DATA. Change
> g_lock to use TDB_DATA keys.
> Review appreciated!

lgtm. Pushed.


Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/

More information about the samba-technical mailing list