[PATCH] Selftest improvements

jim jim.brown at rsmas.miami.edu
Thu Feb 8 03:17:44 UTC 2018


Why do you remove the explicit argument declarations for so many functions?
These declarations help catch usage errors, i.e. wrong number of calling 
arguments, especially when you add arguments to functions.

Example 1:

-sub skip($)
+sub skip
-	my ($name) = @_;
+	my ($name, $envname) = @_;

Example 2:

-sub setup_rpc_proxy($$$)
+sub setup_rpc_proxy
  	my ($self, $path, $dc_vars) = @_;


On 2/7/2018 9:55 PM, Jamie McClymont via samba-technical wrote:
> Agh, you're right!
> I missed the rpc_proxy environment (and can now see that this is the
> only mistake of that type which occurred).
> New patch attached.
> Thanks
> On 08/02/18 15:41, Andrew Bartlett via samba-technical wrote:
>> On Thu, 2018-02-08 at 15:25 +1300, Jamie McClymont via samba-technical
>> wrote:
>>> On 07/02/18 11:01, Jamie McClymont via samba-technical wrote:
>>>> At your request, I'm running some private autobuilds now, attempting to
>>>> confirm that there are no differences in which tests are run.
>>> As some validation that these patches do not reduce the number of tests
>>> being run, below are the sizes of the stdout files for each autobuild
>>> job with none, the first, and both of my commits.
>> Can you also look at this line-wise?  I know some times will change,
>> but I'm really nervous about missing lines.  We should then be able to
>> eliminate the lines that should go missing as 'clearly' they will
>> belong to the excluded environments.
>> Thanks!
>> Andrew Bartlett

More information about the samba-technical mailing list