[PATCH] samba-tools: add computer subcommand

[Javier Bahillo]

HI:


There are actually a number of subcommands which does not look to make 
much sense for me. Others are fine, and I don't mind at all to reuse the 
code from the "user" subcommand, but not doing a copy and paste. 
Specially caught my attention  the "force user to change password at 
next login" as a computer will not have the ability to do this.

Therefore I would suggest Joeg to inpect inside each subcommand and 
think about it and think whether it would be useful for a computer 
account or not, and to remove the not useful ones



Just my two cents ;)


Regards


El 06/02/18 a las 23:12, joeg--- via samba-technical escribió:
> Hi Stefan,
> Thanks for the input.
>
> I thought all user commands need to be mirrored to computer, that’s why I chose to copy user as base and modify.
>
> If that is not true, there are still some valuable work about create/delete computer and related DNS records, etc. Just need to remove the unneeded commands.
>
> Anyway, I will be on leave for 4 weeks from today, let’s wait to see how Björn Baumbach’s patch look like.
>
> Cheers.
>
>> On 7/02/2018, at 10:23, Stefan Metzmacher <metze at samba.org> wrote:
>>
>> Hi Joe,
>>
>> I don't think making a copy of user.py is useful.
>> Most of the stuff doesn't apply to computer accounts.
>>
>> Björn Baumbach also worked on a samba-tool computer commands,
>> I guess he'll post his patches soon.
>>
>> metze
>>
>>> Am 06.02.2018 um 19:49 schrieb joeg--- via samba-technical:
>>> Oops, the patch!
>>>
>>> BTW:
>>>
>>> this patch is based on my previous dns cleanup command and Garming's
>>> improvement patch.
>>>
>>> So please merge this one after those 2 are merged.
>>>
>>> Thanks!
>>>
>>>
>>>> On 07/02/18 07:46, joeg at catalyst.net.nz wrote:
>>>>
>>>> Hi Team,
>>>>
>>>> I added a new `computer` subcommand for samba-tools, which has the
>>>> same set of commands as the `user` command, but work for a computer.
>>>> Most of the code are copied from user command and then adjust for
>>>> computer.
>>>>
>>>> Review appreciated!
>>>>
>>>> Thanks, Joe.
>>>>
>>>> -- 
>>>> Joe Guo
>>>> joeg at catalyst.net.nz
>>>> Catalyst IT
>>
>