[PATCH] samba-tools: add computer subcommand
joeg at catalyst.net.nz
joeg at catalyst.net.nz
Tue Feb 6 22:12:33 UTC 2018
Hi Stefan,
Thanks for the input.
I thought all user commands need to be mirrored to computer, that’s why I chose to copy user as base and modify.
If that is not true, there are still some valuable work about create/delete computer and related DNS records, etc. Just need to remove the unneeded commands.
Anyway, I will be on leave for 4 weeks from today, let’s wait to see how Björn Baumbach’s patch look like.
Cheers.
> On 7/02/2018, at 10:23, Stefan Metzmacher <metze at samba.org> wrote:
>
> Hi Joe,
>
> I don't think making a copy of user.py is useful.
> Most of the stuff doesn't apply to computer accounts.
>
> Björn Baumbach also worked on a samba-tool computer commands,
> I guess he'll post his patches soon.
>
> metze
>
>> Am 06.02.2018 um 19:49 schrieb joeg--- via samba-technical:
>> Oops, the patch!
>>
>> BTW:
>>
>> this patch is based on my previous dns cleanup command and Garming's
>> improvement patch.
>>
>> So please merge this one after those 2 are merged.
>>
>> Thanks!
>>
>>
>>> On 07/02/18 07:46, joeg at catalyst.net.nz wrote:
>>>
>>> Hi Team,
>>>
>>> I added a new `computer` subcommand for samba-tools, which has the
>>> same set of commands as the `user` command, but work for a computer.
>>> Most of the code are copied from user command and then adjust for
>>> computer.
>>>
>>> Review appreciated!
>>>
>>> Thanks, Joe.
>>>
>>> --
>>> Joe Guo
>>> joeg at catalyst.net.nz
>>> Catalyst IT
>
>
More information about the samba-technical
mailing list