[PATCH] Evaluate 'disable netbios' parameter
jra at samba.org
Fri Dec 21 18:11:04 UTC 2018
On Fri, Dec 21, 2018 at 09:04:09AM +0100, Stefan Metzmacher via samba-technical wrote:
> Hi Justin,
> > The following patches evaluate the 'disable_netbios' option prior to making
> > calls to cli_connect_nb() in several places, this bug was reported by a
> > RHEL customer seeing outbound 'netbios-ssn' traffic on port 139 with
> > disable_netbios set in smb.conf.
> > Gitlab CI Passed, merge request below:
> > https://gitlab.com/samba-team/samba/merge_requests/181
> > Please review.
> If we want to make sure we never generate traffic on port 139,
> don't need to catch that in smbsock_connect_send()
> if port 139 is explicitly passed. And don't try a fallback to that?
> What do others think?
Yep, that would be the lowest level to catch it !
We could return NT_STATUS_NOT_SUPPORTED on any
139 connect, and let the upper levels print
the debugs as required.
More information about the samba-technical