[PATCH] Fix wbinfo --sids-to-unix_ids with some unmapped sids

Stefan Metzmacher metze at samba.org
Fri Dec 21 15:41:17 UTC 2018

Hi Volker,

> We have to reply all we have if some SIDs fail to map.
> Review appreciated!

I'd like to have this, but somethings are not clear to me.

Is this an wbinfo only thing?
Or is smbd also affected?
Do we need backports?

Please don't use S-1-5-1000 for the test, it's really
a bug (a different one) that lookup_wellknown_sid() doesn't handle
it. I'll see if I can come up with a fix for that... (we already handle
it in dom_sid_lookup_predefined_name() and we need to unify the code)

The commit message title:
"idmap: In --sids-to-unix-ids, pass back what we have"
is a bit misleading, I first thought it's a patch to wbinfo.c,
can you replace "--sids-to-unix-ids" by _wbint_Sids2UnixIDs().

Does the return code change has any impact on smbd?

Do we have to change to NONE_MAPPED if no mapping is available?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20181221/22d2d32e/signature.sig>

More information about the samba-technical mailing list