[PATCH] Evaluate 'disable netbios' parameter

Stefan Metzmacher metze at samba.org
Fri Dec 21 08:04:09 UTC 2018

Hi Justin,

> The following patches evaluate the 'disable_netbios' option prior to making
> calls to cli_connect_nb() in several places, this bug was reported by a
> RHEL customer seeing outbound 'netbios-ssn' traffic on port 139 with
> disable_netbios set in smb.conf.
> Gitlab CI Passed, merge request below:
> https://gitlab.com/samba-team/samba/merge_requests/181
> Please review.

If we want to make sure we never generate traffic on port 139,
don't need to catch that in smbsock_connect_send()
if port 139 is explicitly passed. And don't try a fallback to that?

What do others think?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20181221/3832b861/signature.sig>

More information about the samba-technical mailing list