Waf rebuilding issue with python3

Douglas Bagnall douglas.bagnall at catalyst.net.nz
Tue Dec 18 04:14:36 UTC 2018


On 13/12/18 11:06 PM, Douglas Bagnall via samba-technical wrote:
>>>
>>> Yes, that is it, the per-exec seed for the hash function used to avoid
>>> hash attacks on production servers.  Attached is a workaround I've
>>> pushed to autobuild while someone finds the rouge hash.
>>
>> It's weird to put randomness into the hash determining the file
>> content. But that's waf for you...
>>
> 
> I can't reproduce it, but buildtools/wafsamba/samba_utils.py around 370
> looks suspicious to me:

Forget that one. Do the affected people have Python 3.5, and the
unaffected people 3.6 or 3.7?

In that case, I suspect the order-preserving nature of the 3.6+ dict is
what is saving some of us.

https://docs.python.org/3.6/whatsnew/3.6.html#whatsnew36-compactdict

Douglas



More information about the samba-technical mailing list