[PATCH] Allow CTDB's TEST_VAR_DIR variable to be relative

Amitay Isaacs amitay at gmail.com
Tue Dec 18 00:09:53 UTC 2018


On Mon, Dec 17, 2018 at 8:57 PM Martin Schwenke via samba-technical
<samba-technical at lists.samba.org> wrote:
>
> Forcing TEST_VAR_DIR to be absolute can make path of Unix domain
> sockets too long in some test suites.  The maximum is only 108
> characters, as per /usr/include/linux/un.h:
>
> #define UNIX_PATH_MAX   108
>
> However, we need to be careful to make sure correct paths are used when
> creating symbolic links.  For simplicity, we make the links target
> absolute.  There are a couple of other similar issues in the test code.
>
> So, fix the potential issues when TEST_VAR_DIR is relative, and then
> allow TEST_VAR_DIR to be relative.
>
> Please review and maybe push...

Pushed to autobuild.

Amitay.



More information about the samba-technical mailing list