[PATCH] Fix CTDB statistics hop count calculations

Amitay Isaacs amitay at gmail.com
Tue Dec 18 00:09:18 UTC 2018


On Mon, Dec 17, 2018 at 8:44 PM Martin Schwenke via samba-technical
<samba-technical at lists.samba.org> wrote:
>
> We have always assumed that the hop count buckets used in CTDB's
> statistics represent powers of 2 hops.  However, the code shifts 2
> places to the right... so divides by 4,  Given 16 buckets, the top
> bucket contains counts higher than 268435456, which is a little
> excessive.
>
> So, divide by 2 instead.
>
> While, the documentation correctly assumed powers of 2, it only had 10
> buckets documented, so fix this.
>
> A 2nd patch improves nearby line wrapping in the documentation for lock
> buckets.
>
> Please review and maybe push...

Pushed to autobuild.

Amitay.



More information about the samba-technical mailing list