Integrate kerberos tracing - part 2

[swen]

Ping.

Comments, anyone please ?

Cheers Swen
On Wed, 2018-12-05 at 19:25 +0100, swen wrote:
> Ok, the first trial of integrating the new MIT tracing with the
> existing Heimdal logging didn't go too well.
> 
> The latest version (attached here) is pretty much what Metze
> mentioned as the first option, an integration of 
> raw krb5_init_context() with the functionality of KRB5_TRACE_SET().
> Now named smb_krb5_init_context_common() and used everywhere in the
> code (Heimdal and MIT).
> 
> An integration on a higher level, e.g. smb_krb5_init_context_basic()
> or
> even smb_krb5_init_context() would have been by far too intrusive to
> the existing code with too little benefit.
> 
> The current version is running test on Gitlab currently and looks
> promising.
> 
> https://gitlab.com/samba-team/devel/samba/commits/sswen-common-kerbeors-tracing
> 
> Please comment.
> 
> Thanks for your support in advance !
> 
> Cheers Swen
> 
> On Wed, 2018-12-05 at 14:29 +0100, swen via samba-technical wrote:
> > Hi Metze,
> > 
> > On Tue, 2018-12-04 at 10:21 +0100, Stefan Metzmacher via samba-
> > technical wrote:
> > > Hi Swen,
> > > 
> > > We already have something similar in smb_krb5_init_context() for
> > > Heimdal. Can you also add the tracing for MIT there?
> > > 
> > > I'm not sure, but I think it might be nicer to then use
> > > smb_krb5_init_context() instead of the raw krb5_init_context()
> > > so that we can't forget KRB5_TRACE_SET().
> > > What does others think about that?
> > > If we decide to use krb5_init_context() + KRB5_TRACE_SET() please
> > > make sure it also works for Heimdal.
> > > 
> > 
> > I have checked the existing code and have modified my code to the
> > direction you suggested.
> > 
> > Not 100% though.
> > 
> > I did integrate the MIT tracing to a common location
> > smb_krb5_init_context_basic() but couldn't move everything 
> > to krb5_init_context.c .
> > That would have required an addtl. dependency of 
> > libkrb5samba to authkrb5 which in turn depends on krb5samba.
> > So circular dependency.
> > 
> > Therefore, I decided to move smb_krb5_init_context_basic() along
> > with
> > the callback to krb5_wrapper and that would work.
> > 
> > Please have a look at the attached patch-set and let me know what
> > you
> > think.
> > 
> > Cheers Swen