./configure --with-system-heimdalkrb5 broken?

[Martin Schwenke]

On Fri, 14 Dec 2018 13:27:18 +1300, Andrew Bartlett
<abartlet at samba.org> wrote:

> On Fri, 2018-12-14 at 11:20 +1100, Martin Schwenke via samba-technical
> wrote:
> > Building Samba -with-system-heimdalkrb5 appears to be broken.
> > 
> > CFLAGS="-O3 -I/usr/include/heimdal" \
> >   ./configure --picky-developer --with-cluster-support \
> >     --abi-check-disable --enable-selftest \
> >     --without-ad-dc --without-json --with-system-heimdalkrb5  
> 
> > However, when compiling I see:
> > 
> >   [211/213] Compiling source4/heimdal/lib/vers/print_version.c
> >   06:47:30 runner ['/home/martins/bin/gcc', '-D_SAMBA_BUILD_=4', '-DHAVE_CONFIG_H=1', '-O3', '-MMD', '-D_GNU_SOURCE=1', '-D_XOPEN_SOURCE_EXTENDED=1', '-DHAVE_CONFIG_H=1', '-DDEVELOPER', '-DDEBUG_PASSWORD', '-fPIC', '-D_REENTRANT', '-D_POSIX_PTHREAD_SEMANTICS', '-DDEVELOPER', '-DDEBUG_PASSWORD', '-DCTDB_HELPER_BINDIR="/usr/local/samba/libexec/ctdb"', '-DLOGDIR="/usr/local/samba/var/log"', '-DCTDB_DATADIR="/usr/local/samba/share/ctdb"', '-DCTDB_ETCDIR="/usr/local/samba/etc/ctdb"', '-DCTDB_VARDIR="/usr/local/samba/var/lib/ctdb"', '-DCTDB_RUNDIR="/usr/local/samba/var/run/ctdb"', '-fstack-protector-strong', '-fstack-clash-protection', '-g', '-Wall', '-Wshadow', '-Wmissing-prototypes', '-Wcast-align', '-Wcast-qual', '-fno-common', '-Werror=address', '-Werror=strict-prototypes', '-Wstrict-prototypes', '-Werror=write-strings', '-Wwrite-strings', '-Werror-implicit-function-declaration', '-Werror=pointer-arith', '-Wpointer-arith', '-Werror=declaration-after-statement', '-Wdeclaration-after
 -sta
> >  tement', '-Werror=return-type', '-Wreturn-type', '-Werror=uninitialized', '-Wuninitialized', '-Wimplicit-fallthrough', '-Werror=strict-overflow', '-Wstrict-overflow=2', '-Wformat=2', '-Wno-format-y2k', '-Wno-format-zero-length', '-Werror=format-security', '-Wformat-security', '-Werror=format', '-DSTATIC_HEIMDAL_VERS_HOSTCC_MODULES=NULL', '-DSTATIC_HEIMDAL_VERS_HOSTCC_MODULES_PROTO=extern void __HEIMDAL_VERS_HOSTCC_dummy_module_proto(void)', '-Isource4/heimdal_build', '-I../../source4/heimdal_build', '-Iinclude/public', '-I../../include/public', '-Isource4', '-I../../source4', '-Ilib', '-I../../lib', '-Isource4/lib', '-I../../source4/lib', '-Isource4/include', '-I../../source4/include', '-Iinclude', '-I../../include', '-Ilib/replace', '-I../../lib/replace', '-Ictdb/include', '-I../../ctdb/include', '-Ictdb', '-I../../ctdb', '-I.', '-I../..', '../../source4/heimdal/lib/vers/print_version.c', '-c', '-o/home/martins/samba/samba/bin/default/source4/heimdal/lib/vers/print_version.c.1.
 o']
> >   In file included from ../../source4/heimdal_build/roken.h:156,
> >   from ../../source4/heimdal/lib/vers/print_version.c:39:
> >   ../../source4/heimdal/lib/roken/roken.h.in:282:10: fatal error: roken-common.h: No such file or directory
> >   #include <roken-common.h>
> >   ^~~~~~~~~~~~~~~~
> >   compilation terminated.
> > 
> > The above doesn't have -I/usr/include/heimdal, which seems to be
> > required:
> > 
> >   $ /usr/bin/krb5-config.heimdal  --cflags
> >   -I/usr/include/heimdal
> > 
> > Any clues?  
> 
> Why is it building that file at all, if it is using the system heimdal?

That may actually be the question I meant to ask...  :-)

Oh, and oops... my configure line for that attempt didn't actually have
-I/usr/include/heimdal in it - that was lazy cut and paste.   I tried
that option in my subsequent attempted workaround, which also failed
because it tried to build in-tree things and failed differently...

I couldn't make it work so I built with in-tree Heimdal instead, without
-O3.

It sure would be good if we could get everything compiling with
CFLAGS="-O3" ./configure --picky-developer...

peace & happiness,
martin