[RFC] Advice on SMB client python bindings?

Stefan Metzmacher metze at samba.org
Wed Dec 12 23:16:28 UTC 2018


Am 12.12.18 um 05:16 schrieb Tim Beale:
> The attached patch is all ready to git am and push. It's got the review
> tags added, and the test changes (currently going through autobuild)
> split out.
> 
> On 12/12/18 4:54 PM, Andrew Bartlett wrote:
>> I've pushed the test changes, the rest looks great as well. 
>>
>> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
>>
>> Metze,
>>
>> Can you push if you are happy?

Pushed.

Can you please push the attached change?
It'll make backporting easier, as it avoids an additional
change from python2 => python3.

Thanks!
metze

-------------- next part --------------
From fe1e77d932e6bcede30de57d4c06d982ef2b3c7e Mon Sep 17 00:00:00 2001
From: Stefan Metzmacher <metze at samba.org>
Date: Thu, 13 Dec 2018 00:10:52 +0100
Subject: [PATCH] selftest/knownfail.d/smb: avoid explicit python version

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Stefan Metzmacher <metze at samba.org>
---
 selftest/knownfail.d/smb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/selftest/knownfail.d/smb b/selftest/knownfail.d/smb
index 32989a813740..3c6324ac7b38 100644
--- a/selftest/knownfail.d/smb
+++ b/selftest/knownfail.d/smb
@@ -1,3 +1,2 @@
 # currently savefile appends rather than overwriting
-samba.tests.smb.samba.tests.smb.SMBTests.test_save_load_text\(ad_dc:local\)
-samba.tests.smb.python2.samba.tests.smb.SMBTests.test_save_load_text\(ad_dc:local\)
+samba.tests.smb.*samba.tests.smb.SMBTests.test_save_load_text\(ad_dc:local\)
-- 
2.17.1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20181213/801f3e37/signature.sig>


More information about the samba-technical mailing list