[RFC] Advice on SMB client python bindings?

Andrew Bartlett abartlet at samba.org
Wed Dec 12 03:54:20 UTC 2018

On Tue, 2018-12-11 at 16:24 +1300, Tim Beale via samba-technical wrote:
> Hi Metze,
> I'm not sure I'm the best person to review all this, but it looked OK to
> me. I made some small changes (explained more below), added my review
> tags, and pushed it back to CI:
> https://gitlab.com/samba-team/devel/samba/pipelines/39657191
> Someone else still needs to review the patches that I authored in the
> series.
> > > python/tests: also initialize the s3 loadparm subsystem
> I've dropped this patch for now. It looks fine, but I don't think it
> needs to go in until later (when we actually switchover the
> samba.tests.smb code to use the source3 bindings). My concern is it only
> fixes the tests and won't fix things like samba-tool. I was wondering if
> we need to add an extra 'lp' param (i.e. along with 'force_smb1',
> 'sign', etc), so a valid (s3) loadparm always gets passed in? Anyway,
> it's something we can discuss further, but it doesn't need to hold up
> these changes.
> > > s3:pylibsmb: make use of protocol independent cli_read_send/recv in
> py_cli_read()
> I made a small tweak to get rid of some unnecessary casts.
> > > s3:libsmb: add cli_write_send/recv which work with SMB1/2/3
> I added some code comments (in a separate patch) to try to explain the
> difference between the new cli_write_send() and cli_push_send().
> Cheers,
> Tim

I've pushed the test changes, the rest looks great as well. 

Reviewed-by: Andrew Bartlett <abartlet at samba.org>


Can you push if you are happy?


Andrew Bartlett
Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

More information about the samba-technical mailing list