[PATCH] loadparm: check for VFS modules required by AD DC role

[David Mulder]

LGTM, rb+

This just adds a warning when dfs_samba4 and acl_xattr aren't enabled
and vfs objects is defined.

Is there any reason we shouldn't consider pre-pending dfs_samba4 and
acl_xattr to vfs objects instead of just giving a warning?

On 11/26/18 11:36 AM, David Disseldorp via samba-technical wrote:
> When Samba is running as an AD compatible domain controller and the
> "vfs objects" parameter is not set, then the dfs_samba4 and acl_xattr
> modules are automatically enabled. However, if the "vfs objects" is
> defined, then the setting is left as-is.
> This means that attempts to us other VFS modules have the side effect of
> disabling the dfs_samba4 and acl_xattr modules, causing unexpected
> behaviour.
>
> This change ensures that when running as a domain controller, Samba logs
> an error if the required VFS modules are not enabled by an explicit
> "vfs objects" definition.
>
> Bug: https://bugzilla.samba.org/show_bug.cgi?id=10560
>
> Cheers, David

-- 
David Mulder
SUSE Labs Software Engineer - Samba
dmulder at suse.com
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)