Merge brlock.tdb and locking.tdb

[Ralph Böhme]

On Mon, Dec 10, 2018 at 09:07:09AM +1100, Martin Schwenke wrote:
>On Fri, 7 Dec 2018 16:05:29 +0100, Ralph Böhme via samba-technical
>> So what about putting the brlock record as raw blob before the share_mode_data
>> into locking.tdb, ie
>>
>> struct locking_tdb_record {
>>         uint32 num_brlocks;
>>         [size_is(num_brlocks)] struct lock_struct brlocks[];
>>
>>         struct share_mode_data share_mode;
>> }
>>
>> Therein only share_mode is NDR encoded, num_brlocks and brlocks[] is not.
>
>Possibly a naive question...
>
>What would including a raw blob mean for the (future) possibility of
>heterogeneous clusters?

well, I'not proposing to *include* a new blob, but to *move* an exisiting one, 
but it's probably a good idea to add a version tag at that point while at it. :)

Eg

struct locking_tdb_record {
        uint32 version;
        uint32 num_brlocks;
        [size_is(num_brlocks)] struct lock_struct brlocks[];

        struct share_mode_data share_mode;
}

-slow

-- 
Ralph Boehme, Samba Team                https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG-Fingerprint   FAE2C6088A24252051C559E4AA1E9B7126399E46