Merge brlock.tdb and locking.tdb

[Martin Schwenke]

On Fri, 7 Dec 2018 16:05:29 +0100, Ralph Böhme via samba-technical
<samba-technical at lists.samba.org> wrote:

> On Sun, Oct 29, 2017 at 08:39:02PM +0100, Volker Lendecke via samba-technical wrote:
> >On Sun, Oct 29, 2017 at 06:25:54PM +0100, David Disseldorp via samba-technical wrote:  
> >> On Sun, 29 Oct 2017 12:29:08 +0100, Ralph Böhme via samba-technical wrote:
> >>  
>  [...]  
> >>
> >> Sounds like a good idea to me.  
> >
> >One argument for keeping brlock.tdb is the fact that we might have to
> >read it MUCH more often to implement mandatory byte range
> >locking. You don't want to parse a potentially large and complex
> >locking.tdb record for every read or write request.  
> 
> So what about putting the brlock record as raw blob before the share_mode_data 
> into locking.tdb, ie
> 
> struct locking_tdb_record {
>         uint32 num_brlocks;
>         [size_is(num_brlocks)] struct lock_struct brlocks[];
> 
>         struct share_mode_data share_mode;
> }
> 
> Therein only share_mode is NDR encoded, num_brlocks and brlocks[] is not.

Possibly a naive question...

What would including a raw blob mean for the (future) possibility of
heterogeneous clusters?

peace & happiness,
martin