[PATCH] Fix undefined behavior in NDR

Stefan Metzmacher metze at samba.org
Fri Dec 7 00:01:25 UTC 2018


Hi Andreas,

>>> Why do we need this if we have checks in ndr_push_bytes()?
>>>
>>> Adding the above two checks in ndr_push_bytes() might also be very
>>> costly. Isn't the first check enough? It should also use unlikely()
>>
>> updated patchset attached ...
> 
> As the patch already landed in master, here is a follow up patch to fix it.

Thanks! Please push.

metze


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20181207/bdc3a710/signature.sig>


More information about the samba-technical mailing list