[PATCH] unsupported python3 syntax in dnspython

Andrew Bartlett abartlet at samba.org
Wed Dec 5 17:56:58 UTC 2018


On Wed, 2018-12-05 at 09:29 +0000, Noel Power wrote:
> On 04/12/2018 21:59, Andrew Bartlett via samba-technical wrote:
> > On Tue, 2018-12-04 at 14:15 -0700, David Mulder via samba-technical
> > wrote:
> > > I caught these running a simple build with python2 blacklisted (and the
> > > python3 binary pointed at python).
> > > 
> > >   third_party/dnspython/dns/message.py | 6 +++---
> > >   1 file changed, 3 insertions(+), 3 deletions(-)
> > I would like to just remove it from third_party at this point, and we
> > can put back a modern version if it causes a massive pain.
> > 
> > Andrew Bartlett
> > 
> +1 for that,
> 
> Here's a patch
> 
> Noel

Can you make a merge request and fix these references?

[abartlet at localhost samba]$ git grep dnspython| grep -v travis
lib/README:dnspython - Python module for working with DNS.
python/samba/emulate/traffic_packets.py:samba.ensure_third_party_module
("dns", "dnspython")
source4/scripting/bin/samba_dnsupdate:samba.ensure_third_party_module("
dns", "dnspython")
source4/scripting/bin/samba_upgradedns:samba.ensure_third_party_module(
"dns", "dnspython")
third_party/update.sh:echo "Updating dnspython..."
third_party/update.sh:git clone
git://git.samba.org/third_party/dnspython "$WORKDIR/dnspython"
third_party/update.sh:rm -rf "$WORKDIR/dnspython/.git"
third_party/update.sh:rsync -avz --delete "$WORKDIR/dnspython/"
"$THIRD_PARTY_DIR/dnspython/"
third_party/wscript:    "dns.resolver": "dnspython/dns",

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba





More information about the samba-technical mailing list