SMB2 and allocation size

[Andreas Schneider]

On Friday, 30 November 2018 13:08:54 CET Andreas Schneider via samba-technical 
wrote:
> On Friday, 30 November 2018 12:42:42 CET Stefan Metzmacher wrote:
> > Hi Andreas,
> 
> Hi Metze,
> 
> > I'd actually like to have the server fixed.
> > We need to provide the behavior of a Windows Server
> > 
> > Should we only look at the block number if size != 0?
> 
> Well, if you look at vfswrap_get_alloc_size() the comment is:
> 
>   Given a stat buffer return the allocated size on disk, taking into
>   account sparse files.
> 
> I thought that is the reason why the size isn't taken into account at all.
> However you could just extend the if-clause and leave early. See attached
> ...
> 
> Ralph discovered that 'store dos attributes = yes' also results in a block
> size of 8.

Ping!


What's the correct fix here?


	Andreas

-- 
Andreas Schneider                      asn at samba.org
Samba Team                             www.samba.org
GPG-ID:     8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D