Integrate kerberos tracing
slow at samba.org
Tue Dec 4 08:46:47 UTC 2018
On Tue, Dec 04, 2018 at 09:42:19AM +0100, swen wrote:
>On Tue, 2018-12-04 at 09:36 +0100, Ralph Böhme wrote:
>> Hi Swen,
>> On Tue, Dec 04, 2018 at 09:26:59AM +0100, swen via samba-technical
>> > This is actually a resend from Nov. 26th with one small but
>> > important
>> > addition.
>> > It now includes an option for 'configure' with which the feature
>> > can be
>> > selected.
>> > This patch set is using krb5_set_trace_callback from the kerberos
>> > API
>> > to provide inline tracing information.
>> > The feature itself must be enabled at compile time by defining
>> > HAVE_KRB5_TRACING, the default is to NOT have tracing compiled in.
>> > As mentioned above, this can be done/enabled now by specifiying the
>> > configuration option --with-krb5-tracing.
>> > If compiled in, the trace information will only be logged if
>> > logging is
>> > set to DEBUG level.
>> > Beside the introduction of the feature (patch 1) the inclusion for
>> > each
>> > area is handled by tiny seperate patches (patch 2 - 10).
>> > If wanted, that could be condensed to one, but I remember that some
>> > prefer it that way.
>> > The last patch (patch 11) contains now the changes to the wscript,
>> > offering the configuration switch.
>> > The entire patch set passed the GitLab test suit and a merge
>> > request is
>> > created as well.
>> > https://gitlab.com/samba-team/samba/merge_requests/123
>> > Please review, comment and maybe push if happy.
>> ENOPATCH. :)
>I though it would be easier to review on GitLab, but yeah you're right,
>should have added the patchset here as well (see attachment).
thanks! I review in an editor, not in gitlab. I have the fancy emacs macro from
Aurelien to fetch patchsets from gitlab merge requests, but others may not. :)
Ralph Boehme, Samba Team https://samba.org/
Samba Developer, SerNet GmbH https://sernet.de/en/samba/
More information about the samba-technical