[PATCH] Fix for bug 12164

[David Mulder]

LGTM. Builds and samba.blackbox.wbinfo tests succeed.
rb+

On Mon, Dec 3, 2018 at 1:11 PM, Ralph Böhme via samba-technical 
<samba-technical at lists.samba.org> wrote:
> On Wed, Nov 28, 2018 at 07:23:12PM +0100, Ralph Böhme wrote:
>> On Wed, Nov 28, 2018 at 03:16:20PM +0100, Ralph Böhme wrote:
>>> On Wed, Nov 28, 2018 at 02:17:16PM +0100, Stefan Metzmacher wrote:
>>>> Am 28.11.18 um 12:51 schrieb Ralph Böhme via samba-technical:
>>>>> Hi!
>>>>> 
>>>>> Attached is a fix for bug 12164.
>>>>> 
>>>>> Fixes lookupnames in winbindd for names in the "NT Authority" 
>>>>> domain.
>>>> 
>>>> find_lookup_domain_from_sid() already has something similar
>>>> using sid_check_is_wellknown_domain() from 
>>>> source3/lib/util_wellknown.c.
>>>> Maybe we want to add a new function there for now.
>>>> 
>>>> It both cases I think it should be routed to the "BUILTIN" domain
>>>> instead of the passdb domain.
>>>> 
>>>> The same applies to "NT Pseudo Domain", "Internet$" and
>>>> "Mandatory Label". Maybe we should have a helper function
>>>> that checks predefined_domains[] in libcli/security/util_sid.c
>>>> 
>>>> Or we remove source3/lib/util_wellknown.c and use the more up to
>>>> date table from libcli/security/util_sid.c, which matches the
>>>> [MS-LSAT] 3.1.1.1.1 Predefined Translation Database and 
>>>> Corresponding View.
>>> 
>>> thanks, I'll check!
>> 
>> updates patchset attached. Passes local make test 
>> TESTS=samba.blackbox.wbinfo.
>> 
>> CI: https://gitlab.com/samba-team/devel/samba/pipelines/38253680
>> 
>> Please review&push if happy.
> 
> anyone? Thanks!
> 
> -slow
> 
> --
> Ralph Boehme, Samba Team                https://samba.org/
> Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
> GPG-Fingerprint   FAE2C6088A24252051C559E4AA1E9B7126399E46
> 
>