[PATCH] Fix the FreeBSD build
abartlet at samba.org
Fri Aug 31 20:29:13 UTC 2018
On Fri, 2018-08-31 at 13:27 -0700, Christof Schmitt wrote:
> On Fri, Aug 31, 2018 at 10:15:35PM +1200, Andrew Bartlett via samba-
> technical wrote:
> > On Fri, 2018-08-31 at 06:27 +0200, Volker Lendecke via samba-
> > technical
> > wrote:
> > >
> > > Hi!
> > >
> > > Review appreciated!
> > >
> > > Thanks, Volker
> > Also seems to be needed to build on current Fedora.
> > Thanks!
> > Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> That was from me, i should have looked closer how other files handle
> these includes. Probably the #include <fcntl.h> can also be removed
> this is then pulled in through filesys.h.
Yes, we avoid bare includes of eg <fcntl.h> and try go go via one of
the system/ headers from libreplace. This avoids littering files all
over the tree with the inevitable #ifdef maze when someone wants to
support 'odd' platforms.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical