[PATCH] Fix failure to update dirpath
obnox at samba.org
Tue Aug 28 23:08:32 UTC 2018
On 2018-08-28 at 14:08 -0700, Jeremy Allison wrote:
> On Wed, Aug 22, 2018 at 01:51:00PM -0700, Jeremy Allison wrote:
> > On Wed, Aug 22, 2018 at 04:35:16PM +0200, Michael Adam wrote:
> > >
> > > I do actually think that this is conceptionally
> > > the much better patch. It fixes the slightly
> > > arbitrary (and undocumented) behavior to return
> > > "" for dirpath in the non-optimized case and had
> > > all callers react to that arbitrary fact. But the
> > > dirpath was not really useful for other processing.
> > >
> > > With this change you always return a valid
> > > dirpath, and we don't need to change it
> > > (to ".") for some callers...
> > >
> > > A few more cosmetic review commments below in the patch.
> > OK, now the "simple" fix has gone in, here is the
> > cleanup patchset for unix_convert() to ensure we
> > always have a valid dirpath (incorporates your
> > comments).
> > Please review and let me know if it's OK.
> Ping ! As you wanted it this way, please take
> the time to review :-).
Yeah, I started.
Hope to complete it tomorrow.
Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 163 bytes
Desc: not available
More information about the samba-technical