[PATCH] Add libsmbclient list shares test

Jeremy Allison jra at samba.org
Tue Aug 28 22:38:54 UTC 2018

On Wed, Aug 29, 2018 at 10:19:30AM +1200, Andrew Bartlett wrote:
> On Tue, 2018-08-28 at 15:14 -0700, Jeremy Allison via samba-technical
> wrote:
> > 
> > Ah, looking at the full log I see:
> > 
> > Listing: smb://Administrator:locDCpass1@addc/tmp
> > 
> > - which explains why it's listing the contents
> > of /tmp. Now, how did list_shares get invoked
> > with /tmp appended to the smb url ?
> To be clear [tmp] is one of the standard shares in all our selftest
> environments.  It doesn't map to the host /tmp, just somewhere under
> our per virtual server selftest area.

Yeah, I know - I was just using /tmp as a shorthand.

What I'm trying to debug is the fact that the new
code has:


libsmbclient = smbtorture4_testsuites("libsmbclient.")
for t in libsmbclient:
    url = "smb://$USERNAME:$PASSWORD@$SERVER/tmp"
    if "list_shares" in t:
        url = "smb://$USERNAME:$PASSWORD@$SERVER"

so for the 'list_shares' test it should have
removed the /tmp from the end, and didn't.

More information about the samba-technical mailing list