[PATCH] Fix failure to update dirpath

Jeremy Allison jra at samba.org
Wed Aug 22 15:59:50 UTC 2018

On Wed, Aug 22, 2018 at 04:35:16PM +0200, Michael Adam wrote:
> I do actually think that this is conceptionally
> the much better patch. It fixes the slightly
> arbitrary (and undocumented) behavior to return
> "" for dirpath in the non-optimized case and had
> all callers react to that arbitrary fact. But the
> dirpath was not really useful for other processing.
> With this change you always return a valid
> dirpath, and we don't need to change it
> (to ".") for some callers...

FYI. The only called functions that (currently)
care are the get_real_filename() and friends
which is the one already being fixed in this

> A few more cosmetic review commments below in the patch.

I'll use these to update the "comprehensive"
patch and re-post for you to review, thanks !

But the "simple" patch is what should go into
4.9.x and below (after going into master

More information about the samba-technical mailing list