[PATCH] Fix failure to update dirpath

Jeremy Allison jra at samba.org
Wed Aug 22 15:56:37 UTC 2018

On Wed, Aug 22, 2018 at 11:32:19AM +0530, Anoop C S wrote:
> On Tue, 2018-08-21 at 09:54 -0700, Jeremy Allison wrote:
> > 
> > FYI, the attached diff is the full clean-up
> > that is required to make everything
> > work correctly (otherwise it fails in the
> > samba3.blackbox.smbclient_s3.SMB3.plain
> > test).
> Ok. We have few other checks on "dirpath" for '\0' inside unix_convert() which we  missed in
> previous version which might have caused the test failures. And I see that "dirpath" is now being
> allocated to "." by default.
> Glad to hear that this comprehensive change also passed autobuild.

Well it passed that specific test :-). I still need
to look at this much more carefully to understand
if it really is the right thing first (forgot to
check what is being put into the stat-cache with
this change).

More information about the samba-technical mailing list