[PATCH] Fix Gluster bug - unable to create file/directory under root of the share due to empty dirpath during get_real_filename()

Jeremy Allison jra at samba.org
Wed Aug 22 15:45:55 UTC 2018

On Wed, Aug 22, 2018 at 04:37:16PM +0200, Michael Adam wrote:
> As detailed in the original thread, I think this
> patch is kind of emphasising the arbitrariness of
> the current check_parent_exists() function and
> the other, bigger patch is IMHO the conceptually
> much better patch. Can we reconsider that one?

I don't think that's a good idea for this specific
bug, which only affects Gluster.

Once this patch has gone in then we can look at
cleaning up this code in source3/smbd/filename.c,
but that has to be done *much* more carefully.

Please review this one, then I promise I'll
finish up my cleanup :-).


More information about the samba-technical mailing list