[RFC PATCH v5] add JSON output to net ads
abartlet at samba.org
Tue Aug 21 21:12:30 UTC 2018
On Tue, 2018-08-21 at 08:29 +0200, Philipp Gesang via samba-technical
> Hey guys,
> this iteration addresses the comments to v4 by Andrew Bartlett
> (tests, merge conflicts).
> CI: https://gitlab.com/phgsng/samba/pipelines/28267867
> A note on the tests: Instead of making the code that parses the
> non-JSON output more permissive I chose to make the output of
> “net ads lookup” more regular. As a consequence, The blackbox
> tests now depend on this change. I’m aware that this change is
> not entirely related to the patch series. If it is not acceptable
> let me know and I’ll tweak the test code accordingly.
I'm still stumped as to how your patches differ from the ones that Gary
had where we just couldn't make --json work.
Can you push it to the https://gitlab.com/samba/devel/samba repo so we
can see the full test run please?
Can you please ensure your tests catch exceptions. Allowing
BlackboxProcessError seems quite wrong, that is exactly the type of
error you should be looking for.
Finally if you run this against chgdcpass rather than the main
ad_dc_ntvfs and ad_dc environments you will have it run in your more
limited CI environment. In a comment just explain that as this does
not log in, we can spread the load and run it against another
(Only the build_samba_ad_dc_2 runs in private repos, sadly the rest of
the AD DC tests don't fit in the smaller free VMs provided by
Authentication Developer, Samba Team https://samba.org
Samba Development and Support, Catalyst IT
More information about the samba-technical