[PATCH] for "testparm should check for invalid vfs objects"
amitkuma at redhat.com
Tue Aug 21 10:32:45 UTC 2018
I tried using getting vfs_object list as done in smbd_vfs_init(), Since
I donot have connection_struct i used #define GLOBAL_SECTION_SNUM
(-1). But values are not retrieved.
int test = -1, o=0;
char **vfs_objects_test = lp_vfs_objects(test);
Also have do we have any module extracted using 'waf' which can refereed
as for reference.
On 08/20/2018 04:29 PM, Amit wrote:
> Hey Metze/Volker,
> I appreciate your response. Yes you are absolutely right. I will try
> to look into both approaches to parses object list.
> On 08/20/2018 04:18 PM, Volker Lendecke wrote:
>> On Mon, Aug 20, 2018 at 12:12:21PM +0200, Stefan Metzmacher via samba-technical wrote:
>>> I think we should better just try to load the listed modules,
>>> similar to smbd_vfs_init(). It highly depends on the build which
>>> modules are available and having a hardcoded list in testparm,
>>> will just give wrong results.
>> Alternatively we could try to extract the compiled VFS modules from
>> waf and put the list into a #define. But hard-coding is problematic
>> IMHO. This is very prone to bit-rot over time.
>> My 2ct.
> Amit Kumar
> !!If you stumble, get back up.
> What happened yesterday, no longer matters.
> Today is another day to move closer to your GOAL!!
!!If you stumble, get back up.
What happened yesterday, no longer matters.
Today is another day to move closer to your GOAL!!
More information about the samba-technical