[PATCH] Fix failure to update dirpath

Anoop C S anoopcs at autistici.org
Mon Aug 20 11:47:54 UTC 2018

On Sat, 2018-08-18 at 17:02 +0530, Anoop C S via samba-technical wrote:
> Hi,
> Please find the attached patch which updates dirpath where it failed to do so in
> check_parent_exists().

Attached is a modified version with a change to where goto label was placed in the previous version
of the patch so as to update "start" component too. This should be it.

> Tested with GlusterFS as backend file system.
> Reviews are appreciated.

Ok.. so a quick re-look at the patch made me think it being too generic to update "start" and
"dirpath" in 3 cases rather than specific to the case where last_component and smb_fname are equal. 

Hmm.. actually it should not cause any harm to further processing down the line. Just noting it down
here to help whoever wants to review the change.

> Anoop C S
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dirpath-update-v2.patch
Type: text/x-patch
Size: 3052 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180820/3b12773f/dirpath-update-v2.bin>

More information about the samba-technical mailing list