[PATCH] for "testparm should check for invalid vfs objects"

Volker Lendecke Volker.Lendecke at SerNet.DE
Mon Aug 20 10:48:31 UTC 2018


On Mon, Aug 20, 2018 at 12:12:21PM +0200, Stefan Metzmacher via samba-technical wrote:
> I think we should better just try to load the listed modules,
> similar to smbd_vfs_init(). It highly depends on the build which
> modules are available and having a hardcoded list in testparm,
> will just give wrong results.

Alternatively we could try to extract the compiled VFS modules from
waf and put the list into a #define. But hard-coding is problematic
IMHO. This is very prone to bit-rot over time.

My 2ct.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

Meet us at Storage Developer Conference (SDC)
Santa Clara, CA USA, September 24th-27th 2018



More information about the samba-technical mailing list