[PATCH] Fix bug 13465

Volker Lendecke Volker.Lendecke at SerNet.DE
Thu Aug 16 05:46:49 UTC 2018


On Wed, Aug 15, 2018 at 02:40:48PM -0700, Christof Schmitt via samba-technical wrote:
> Sharing the common code is good, but i am wondering if the post hook in
> popt is the best place for that. Right now i am exploring whether a
> cleaner approach would be:
>  
>  - Move the complex calls from the post hook to a helper function that
>    can be called from the cmdline tools (there is already
>    source3/lib/util_cmdline.c which might be a good place).
>  - Introduce a new cmdline_contexts.c, similar to server_contexts, but
>    with the additional checks for cmdline tools.
>  - That would require introducing a "set" function for the messaging
>    context used in db_open.

Thanks for looking into that mess! On your last point -- what would
that mean? Being able to change a messaging context on an existing
db_context?

Thanks, Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

Meet us at Storage Developer Conference (SDC)
Santa Clara, CA USA, September 24th-27th 2018



More information about the samba-technical mailing list