[PATCH] Small fix to the ldb tests
Timur I. Bakeyev
timur at freebsd.org
Tue Aug 14 01:20:34 UTC 2018
On 14 August 2018 at 02:06, Jeremy Allison <jra at samba.org> wrote:
> On Tue, Aug 14, 2018 at 10:47:30AM +1200, Douglas Bagnall via
> samba-technical wrote:
> > Thanks Timur,
> > On 14/08/18 09:03, Timur I. Bakeyev via samba-technical wrote:
> > > I came across this wrong assertion while ago and, seems, it still
> there, at
> > > least in ldb 1.4.1.
> > >
> > > We are allocating msg02, but check in assertion msg01, which makes no
> > > here.
> > There is an instance of that in master, but it isn't here:
> > > @@ -3529,7 +3529,7 @@ static void test_ldb_unique_index_duplic
> > and the patch would be easier to deal with if these paths started with
> > lib/ldb:
> > > --- tests/ldb_mod_op_test.c.orig 2018-03-02 23:35:09 UTC
> > > +++ tests/ldb_mod_op_test.c
> > ...and it had a commit message.
> > I have attached a fixed version; all you need to do is add your
> > sign-off above the reviewed-by and get someone else to review it.
> RB+ by me, obvious goodness. Timur, give me your permission
> to add your Signed-off-by: and I'll push.
Sure, Jeremy, you are always have my blessing!
Douglas, sorry it came this way, I normally do 'git format-patch', but this
one came from the
the old LDB 1.3.4 standalone port which I was removing in favor of the
bundled LDB. Still,
too bad you had to do my homework, sorry again.
With best regards,
More information about the samba-technical