[PATCH] Small fix to the ldb tests

Douglas Bagnall douglas.bagnall at catalyst.net.nz
Mon Aug 13 22:47:30 UTC 2018

Thanks Timur,

On 14/08/18 09:03, Timur I. Bakeyev via samba-technical wrote:
> I came across this wrong assertion while ago and, seems, it still there, at
> least in ldb 1.4.1.
> We are allocating msg02, but check in assertion msg01, which makes no sense
> here.

There is an instance of that in master, but it isn't here:

> @@ -3529,7 +3529,7 @@ static void test_ldb_unique_index_duplic

and the patch would be easier to deal with if these paths started with

> --- tests/ldb_mod_op_test.c.orig	2018-03-02 23:35:09 UTC
> +++ tests/ldb_mod_op_test.c

...and it had a commit message.

I have attached a fixed version; all you need to do is add your
sign-off above the reviewed-by and get someone else to review it.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ldb-tests-fix-assertion-on-wrong-pointer.patch
Type: text/x-patch
Size: 969 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180814/e832bcb9/0001-ldb-tests-fix-assertion-on-wrong-pointer.bin>

More information about the samba-technical mailing list