[PATCH] Fix a few CIDs
jra at samba.org
Mon Aug 13 16:24:36 UTC 2018
On Mon, Aug 13, 2018 at 01:13:42PM +0100, Noel Power wrote:
> On 08/08/18 19:19, Jeremy Allison via samba-technical wrote:
> > On Wed, Aug 08, 2018 at 05:52:31PM +0200, Volker Lendecke via samba-technical wrote:
> >> Hi!
> >> Plus a small cleanup
> >> Review appreciated!
> > LGTM, thanks for catching these. Sorry I missed them
> > in the original review (but Coverity helps a lot :-).
> yeah, sorry for creating them :/ +1 for coverty
> > Noel we probably need these merged into the bug back-port.
> what's procedure here for the backports, unfortunately I missed the
> opportunity to merge these into the backported patch as they have been
> pushed to 4.8/4.9 already. Should I add the quota bug number e.g. ( Bug
> 13553 ) tag the these patches and add these patches then to
> https://bugzilla.samba.org/show_bug.cgi?id=13553 aswell ? or open a new
> Bug (which won't be reflected in the patches already in master). Not
> sure what the correct procedure is (sorry, seem to be making a pigs ear
> out of this)
They're part of the same bug, so re-open the bug, re-assign it
to yourself and then upload the new patches as "additional" and
ask me to review.
Once I'm done I'll re-assign to Karolin to add the new set
No worries, you're fixing a major feature (which is sorely
needed :-) so don't worry about minor proceedual hiccups !
More information about the samba-technical