[PATCH] semi-autoformat to PEP8

Andrew Bartlett abartlet at samba.org
Sun Aug 12 23:21:44 UTC 2018

On Fri, 2018-08-10 at 08:46 +0300, Alexander Bokovoy wrote:
> On pe, 10 elo 2018, Andrew Bartlett via samba-technical wrote:
> > I've got a WIP merge request here to auto-format (with manual
> > adjustments) Samba's python code to pep8.
> > 
> > The main work is by Joe and Tim with feedback from Douglas.
> > 
> > I would like comments on this so we can merge it soon, once I finish my
> > own review.  I realise wholesale code re-formatting isn't a tradition
> > in Samba, so this is confined (naturally) to python code and to
> > compliance with python coding guidelines.
> > 
> > https://gitlab.com/samba-team/samba/merge_requests/48
> > 
> > Please comment!
> Please don't do that until I merge waf upgrade. I'm at 80+ patches there
> and it is hard enough to rebase already.

I certainly appreciate that.  No buildtools, waf or wscript files are
changed by this patch series (deliberately).  Is there anything else we
should watch out for?

> I'm working on incorporating the changes you asked me in July but
> between some internal deadlines and conferences I have what I have with
> my time.

Any idea when you will be able to present this?  

Given the above, would it be possible to land this prior?


Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

More information about the samba-technical mailing list