[PATCH] Fix several memory and resource leaks
Volker.Lendecke at SerNet.DE
Fri Aug 10 11:31:33 UTC 2018
On Fri, Aug 10, 2018 at 09:56:05AM +0200, Andreas Schneider via samba-technical wrote:
> On Thursday, 9 August 2018 21:01:31 CEST Jeremy Allison wrote:
> > On Thu, Aug 09, 2018 at 11:16:08AM -0700, Jeremy Allison via samba-technical
> > > Ah, Looks like Volker also had some good comments.
> > >
> > > I won't push anything, I'll wait until you
> > > address both his and my comments (some of
> > > which were the same :-).
> > >
> > > Feel free to push the ones that both Volker
> > > and I reviewed without comment though :-).
> > Just to be helpful, these are the ones that
> > both Volker and I +1'ed (although you might
> > want to look at his comments about re-arranging
> > around the 'continue's in the last patch.
> Attached is an updated patchset. There are 4 patches with need to be reviewed
> I've dropped one patch which was a false positive. I've reordered the patches
> that the already reviewed patchsets are at the beginning. When I modified a
> patch I removed the RB tags.
You didn't like my comment on rearranging the nss_init() code? As I
said, the code looks correct, but the flow is more confusing to me
than it needs to be.
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
Meet us at Storage Developer Conference (SDC)
Santa Clara, CA USA, September 24th-27th 2018
More information about the samba-technical