[PATCH] Fix bug 13204

[Anoop C S]

On Thu, 2018-08-09 at 10:27 -0700, Jeremy Allison wrote:
> On Thu, Aug 09, 2018 at 09:39:41PM +0530, Anoop C S wrote:
> > On Thu, 2018-08-09 at 15:32 +0530, Anoop C S via samba-technical
> > wrote:
> > > On Thu, 2018-08-09 at 14:09 +0530, Anoop C S via samba-technical
> > > wrote:
> > > > Hi,
> > > > 
> > > > Please find the attached patch which fixes the following bug:
> > > > 
> > > > https://bugzilla.samba.org/show_bug.cgi?id=13204 - rmdir on
> > > > non-empty directory fails silently
> > > > 
> > > > For discussion regarding this please refer the thread
> > > > 
https://lists.samba.org/archive/samba-technical/2018-August/129491.html
> > > > 
> > > > Reviews are appreciated.
> > > 
> > > Attaching a slightly modified version of patch with changes only
> > > to commit message.
> > 
> > Ah.. forgot to close the directory :-)
> > 
> > Modified the patch to close fnum before returning
> > NT_STATUS_DIRECTORY_NOT_EMPTY while trying to set
> > DELETE_ON_CLOSE.
> 
> LGTM. I've also included your original base.deltest20c patch
> in this set (with one deleted unused variable definition to
> make it compile :-)

Ah.. most probably a copy/paste error. Thanks.

> but this also needs another test. Your
> deltest20c checks that Windows does what we expect, but you
> weren't testing that your new libsmb client code also worked :-).
> The following set also includes an additional test inside
> test_smbclient_s3.sh that exercises your new code (it works :-).

My bad. Thanks for taking care of that part too. will keep that in mind
for future.

> Passes local make test.
> 
> Can I get a second Team reviewer so I can push ?
> 
> Thanks,
> 
> Jeremy