[PATCH] Add support for MS Catalog files

[Andrew Bartlett]

On Thu, 2018-08-09 at 13:30 +0200, Andreas Schneider wrote:
> On Tuesday, 7 August 2018 23:37:21 CEST Andrew Bartlett wrote:
> > On Tue, 2018-08-07 at 12:21 -0700, Jeremy Allison via samba-technical
> > 
> > wrote:
> > > On Tue, Aug 07, 2018 at 11:40:39AM +0200, Andreas Schneider wrote:
> > > > Updated patchset attached.
> > > > 
> > > > 
> > > > Thanks for the review!
> > > 
> > > LGTM. Really nice, clean code - thanks !
> > > 
> > > Reviewed-by: Jeremy Allison <jra at samba.org>
> > > 
> > > However, it adds a dependency on the package libtasn1-bin
> > > for the ans1Parser program.
> > > 
> > > You'll need to get root at sn-devel to install that,
> > > or change the patch to gate the compilation of this binary on
> > > availability of libtasn1-bin, as currently it won't
> > > configure without it.
> > 
> > Also the package list used to build the docker image needs to be
> > updated:
> > http://git.catalyst.net.nz/gitweb?p=samba-cloud-autobuild.git;a=blob;f=
> > package-lists/ubuntu-1404
> > http://git.catalyst.net.nz/gitweb?p=samba-cloud-autobuild.git;a=blob;f=
> > package-lists/ubuntu
> > 
> > Then the docker container needs to be rebuilt (someone just has to re-
> > run an ansible script), and the .travis-ci.yml file needs to be
> > updated.
> 
> OK, libtasn1-bin is missing but this is not a hard requirement anymore. If it 
> isn't found mscat support isn't build. Maybe you want to add this in the 
> ubuntu >= 14.04 container. If not, sooner or later it will be in autobuild if 
> we update to 18.04.

I did that yesterday.  I'm looking forward to sn-devel being upgraded,
or perhaps being able to have autobuild run in docker so that becomes
less of a drama. 

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba