[PATCH] Fix several memory and resource leaks

jim jim.brown at rsmas.miami.edu
Thu Aug 9 14:59:35 UTC 2018


This chunk looks wrong. Should it be close(newhandle)?

On 8/9/2018 10:53 AM, Andreas Schneider via samba-technical wrote:
> @@ -1181,6 +1182,9 @@ static int do_get(const char *rname, const char *lname_in, bool reget)
>   				      NULL);
>   		if(!NT_STATUS_IS_OK(status)) {
>   			d_printf("getattrib: %s\n", nt_errstr(status));
> +			if (newhandle) {
> +				close(handle);
> +			}
>   			return 1;
>   		}
>   	}




More information about the samba-technical mailing list