[PATCH] s3: vfs: time_audit: fix handling of token_blob in smb_time_audit_offload_read_recv()

Ralph Wuerthner ralphw at de.ibm.com
Thu Aug 9 14:15:23 UTC 2018


Hi list,

please see attached patch to fix a defect within vfs_time_audit. When 
using vfs_time_audit smbtorture test case smb2.ioctl.req_resume_key is 
failing with the following error message:

Using seed 1533822459
time: 2018-08-09 15:47:39.669901
test: req_resume_key
time: 2018-08-09 15:47:39.670594
time: 2018-08-09 15:47:39.712858
failure: req_resume_key [
../source4/torture/smb2/ioctl.c:104: status was 
NT_STATUS_INTERNAL_ERROR, expected NT_STATUS_OK: 
FSCTL_SRV_REQUEST_RESUME_KEY
]

A similar failure can be seen by using vfs_fruit and vfs_time_audit when 
running vfs.fruit.copyfile:

Using seed 1533822525
time: 2018-08-09 15:48:45.461933
test: copyfile
time: 2018-08-09 15:48:45.464498
WARNING!: ../source4/torture/vfs/fruit.c:2482: status was 
NT_STATUS_NO_MEMORY, expected NT_STATUS_OK: FSCTL_SRV_REQUEST_RESUME_KEY
time: 2018-08-09 15:48:45.548604
failure: copyfile [
../source4/torture/vfs/fruit.c:2637: setup copy chunk error
]

Dump question: wouldn't it make sense to run all self tests with 
vfs_time_audit enabled as this module is by definition a no-op?

Regards

Ralph
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-vfs-time_audit-fix-handling-of-token_blob-in-smb_.patch
Type: text/x-patch
Size: 1557 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180809/cdfc86dd/0001-s3-vfs-time_audit-fix-handling-of-token_blob-in-smb_.bin>


More information about the samba-technical mailing list