[PATCH] Add support for MS Catalog files
abartlet at samba.org
Tue Aug 7 21:37:21 UTC 2018
On Tue, 2018-08-07 at 12:21 -0700, Jeremy Allison via samba-technical
> On Tue, Aug 07, 2018 at 11:40:39AM +0200, Andreas Schneider wrote:
> > Updated patchset attached.
> > Thanks for the review!
> LGTM. Really nice, clean code - thanks !
> Reviewed-by: Jeremy Allison <jra at samba.org>
> However, it adds a dependency on the package libtasn1-bin
> for the ans1Parser program.
> You'll need to get root at sn-devel to install that,
> or change the patch to gate the compilation of this binary on
> availability of libtasn1-bin, as currently it won't
> configure without it.
Also the package list used to build the docker image needs to be
Then the docker container needs to be rebuilt (someone just has to re-
run an ansible script), and the .travis-ci.yml file needs to be
Not the end of the world, just needs to be kept in sync for our sanity.
Patches to bring this list into master and to automatically populate
all the different outputs (there are also packer scripts) would be most
I've pre-emptivly done the above (except for the root stuff, naturally)
and the .travis-ci.yml, please just include that in the patch.
Authentication Developer, Samba Team https://samba.org
Samba Development and Support, Catalyst IT
More information about the samba-technical