[PATCH] CTDB - typo and cid fixes (bug 13554)
amitay at gmail.com
Thu Aug 2 07:30:32 UTC 2018
On Thu, Aug 2, 2018 at 4:43 PM, Volker Lendecke
<Volker.Lendecke at sernet.de> wrote:
> On Thu, Aug 02, 2018 at 04:38:03PM +1000, Amitay Isaacs wrote:
>> On Thu, Aug 2, 2018 at 4:29 PM, Volker Lendecke
>> <Volker.Lendecke at sernet.de> wrote:
>> > On Thu, Aug 02, 2018 at 03:20:52PM +1000, Amitay Isaacs via samba-technical wrote:
>> >> Hi,
>> >> Please review and push.
>> > Shouldn't the second one add a "goto done" to avoid short-term leaks?
>> > Likewise for the other "return ENOMEM" checks?
>> The cmdline_run() function creates a temporary context for the cmdline
>> functions and then frees the temorary context. So there is no need to
>> do anything special in each individual cmdline function.
> Why all the talloc_free's after done: then, and there *is* a "goto
> done:" inside instead of a "return ret;". This is at least not 100%
Hmm.. I'll have words with the $(git blame ...) ;-)
> Apart from that bike-shedding, RB+.
Pushed to autobuild.
More information about the samba-technical