[PATCH] CTDB - typo and cid fixes (bug 13554)

Amitay Isaacs amitay at gmail.com
Thu Aug 2 06:38:03 UTC 2018


On Thu, Aug 2, 2018 at 4:29 PM, Volker Lendecke
<Volker.Lendecke at sernet.de> wrote:
> On Thu, Aug 02, 2018 at 03:20:52PM +1000, Amitay Isaacs via samba-technical wrote:
>> Hi,
>>
>> Please review and push.
>
> Shouldn't the second one add a "goto done" to avoid short-term leaks?
> Likewise for the other "return ENOMEM" checks?

The cmdline_run() function creates a temporary context for the cmdline
functions and then frees the temorary context.  So there is no need to
do anything special in each individual cmdline function.

Amitay.



More information about the samba-technical mailing list